Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

fix nav spacing#309

Merged
zacklitzsinger merged 1 commit into
masterfrom
fix-nav-spacing
Sep 23, 2019
Merged

fix nav spacing#309
zacklitzsinger merged 1 commit into
masterfrom
fix-nav-spacing

Conversation

@zacklitzsinger

Copy link
Copy Markdown
Contributor

Changes to Existing Components

  • The navigation component was having specificity issues in styled-components 4.2.0, so I removed the offending CSS. I believe this CSS didn't actually do anything useful anyway.

@a-type

a-type commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

It's for stacked item lists. That particular rule would match if we had two full-size lists on top of one another, which never happens.

@SmithPR SmithPR requested a review from gforrest-bw September 20, 2019 20:03
@zacklitzsinger zacklitzsinger merged commit 84eab45 into master Sep 23, 2019
@zacklitzsinger zacklitzsinger deleted the fix-nav-spacing branch September 23, 2019 14:10
@Bandwidth Bandwidth deleted a comment from vinks Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants